Ruby on Rails Thursday, March 28, 2013

Redirect ends current request and starts a new one, so you are right that that's the case (another action isn't called nor its template rendered). But shouldn't you also test that admin user is still there (wasn't deleted) after redirect happened? You could have very easily have him deleted in your actual code and still redirect to root_path, making this spec pass incorrectly.

2013/3/28 Jussi Hirvi <jushirvi@gmail.com>
Ok, now I have to ask. I am doing exercise 9.9 from the RoR tutorial (3.2). 

I have this rspec/capybara test to make sure that admin user cannot delete him/herself: 

  subject { page }
  . . .
  describe "as admin user" do
      let(:admin) { FactoryGirl.create(:admin) }
      before { sign_in admin }
      describe "submitting a DELETE request to the Users#destroy action" do
        before { delete user_path(admin) }
        specify { response.should redirect_to(root_path) }
        # cannot get the following test to work, even though in browser it works
        # it { should have_selector('div.alert.alert-error') }
      end
    end
 
The test works otherwise ok, but the commented-out line fails when it shouldn't. I verified in browser that the flash error message does in fact appear - here is the html (hope the html entities for greater-than and less-than will be parsed in the following):  
    &lt;div class="alert alert-error"&gt;Admin cannot destroy him/herself.&lt;/div&gt;  
 
Does this have to do with the fact that the server response involves redirect? How could this be fixed? I can live without this test, but I may need the info later. 

- Jussi

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msg/rubyonrails-talk/-/k7HUBM1FF8cJ.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To post to this group, send email to rubyonrails-talk@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

No comments:

Post a Comment