Ruby on Rails Thursday, December 5, 2019

I'm not really sure what's your intention and what's the state of the @item instance. And I have to admit your namings are really confusing "item.item_item_properties" looks too repetitive, are `iip` and `item_item_property` on both loops the same class? does @item have all the item_item_properties?

I think I would do

<%= f.fields_for :item_item_properties do |iip| %>
  <div class="item_item_property">
    <%= iip.label iip.item_property.name %>
    <%= iip.hidden_field :item_property_id, value: iip.item_property_id %>
    <%= iip.text_field  :text_value, value: iip.text_value %>
  </div>
<% end %>

But I'm not sure that's your intention.

Also, a TD inside a DIV is not valid HTML, it will brake your template


El jue., 5 dic. 2019 a las 8:04, fugee ohu (<fugee279@gmail.com>) escribió:


On Wednesday, December 4, 2019 at 3:39:35 PM UTC-5, Ariel Juodziukynas wrote:
Your form_for uses the @item? if so you are already looping through it's item_item_properties, yo don't need to loop again inside fields_for, you already have iip defined, that's why you have everything multiplied

El mié., 4 dic. 2019 a las 11:55, fugee ohu (<fuge...@gmail.com>) escribió:
This snippet duplicates all the expected fields times 8

           <%= f.fields_for :item_item_properties do |iip| %>
                      <div class="item_item_property">
                          <% @item.item_item_properties.each do |item_item_property| %>
                                <tr><td><%= iip.label item_item_property.item_property.name %><td><%= iip.hidden_field :item_property_id, value: item_item_property.item_property_id %> <%= iip.text_field  :text_value, value: item_item_property.text_value %>
                         <% end %>
                      </div>
            <% end %>

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonra...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/f72416d0-72cd-48b4-a6b1-13a55909d59f%40googlegroups.com.

Can you please show me how you would re-write the code block using the magical iteration of @item

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/54a65988-5012-4c85-99be-43a4380e2710%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-talk+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/CAPS3bcB-mo2A6W-ET1-QpaVWOWdRm%2Bxc%2BbpHsf_SNbSiUU%3DXAg%40mail.gmail.com.

No comments:

Post a Comment